Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rebase] Add s3 canned ACL support #779

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

rzvoncek
Copy link
Contributor

This PR is a rebase of #189 on top of the current main.
The storage implementation has changed a lot since 189 was opened, so I had to rework things a bit.
I've tried adding ITs for the ACLs, but it's not easy. To begin with, we'd need a ACL-enabled bucket, which I'm hesitant to create.

Superseeds #189.
We don't have an issue.

Copy link

No linked issues found. Please add the corresponding issues in the pull request description.
Use GitHub automation to close the issue when a PR is merged

@rzvoncek rzvoncek changed the title Radovan/rebase 189 [Rebase] Add s3 canned ACL support Jun 17, 2024
@rzvoncek rzvoncek force-pushed the radovan/rebase-189 branch 2 times, most recently from f955568 to 38d1307 Compare June 17, 2024 12:42
Copy link

sonarcloud bot commented Jun 20, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants